Skip to content

hardware: remove legacy model validation classification - #54

Merged
mksolutionsuniversal merged 2 commits into
mainfrom
release/0.5.0-rc.2-remove-model-validation
Sep 8, 2026
Merged

hardware: remove legacy model validation classification#54
mksolutionsuniversal merged 2 commits into
mainfrom
release/0.5.0-rc.2-remove-model-validation

Conversation

@mksolutionsuniversal

Copy link
Copy Markdown
Owner

Summary

Remove the obsolete per-model validation-classification layer from the current BCPC product path.

SupportedIntelMac is now determined directly from detected Apple hardware plus an Intel CPU. Exact Mac model identity remains hardware/reporting context and may still be used where there is a specific compatibility or research reason, but it does not grant normal processor-profile or fan-write permission.

Product behavior

  • Any detected Apple + Intel system resolves to SupportedIntelMac without a model whitelist.
  • Gaming Optimised remains the global 95% / 95% + Boost Disabled processor policy for SupportedIntelMac.
  • Fan writes remain independently gated by the live AppleSMC capability fingerprint and all existing safety/ownership/recovery checks.
  • Overview removes the legacy Model validation row.
  • Supported Intel Macs show only Platform support in Compatibility; Details is shown only for unsupported or incomplete detection states.
  • Compatibility/diagnostic reports retain the Mac model identifier, platform support, Gaming eligibility, power/Restore state and full fan capability diagnostics, while removing tested/untested classification fields.

Cleanup

Removed obsolete production types:

  • ModelValidationLevel
  • ModelSupportRegistry
  • IModelSupportRegistry
  • ModelSupportDefinition

VerifiedHardwareModels.MacBookPro14_3 was also removed as an obsolete fixture constant.

VerifiedHardwareModels.MacBookPro16_1 intentionally remains only for bounded legacy/research uses, including the 0.4.0-compatible legacy ownership-marker schema and the dedicated physical SMC round-trip research tool. These uses do not grant application fan-write permission.

Safety boundary

No production changes were made under:

  • FanControl/
  • PowerManagement/
  • Profiles/
  • SettingsBackup/
  • drivers/

No SMC key, payload, mask, RPM conversion, writer ordering, ownership journal, crash recovery, Restore ordering, or processor target was changed.

Validation

Local validation on the branch:

  • git diff --check: PASS
  • Release build: PASS, 0 warnings / 0 errors
  • Tests: 632 / 632 PASS, 0 skipped
  • release packaging: PASS
  • prohibited release-content scan: PASS
  • physical SMC writes: 0
  • BCPC was not launched during this cleanup

Release note

This is a pre-release architecture/UI cleanup for the 0.5.0-rc.2 development target. It does not create or publish the release; final release-prep documentation and artifact checkpoint remain separate.

@mksolutionsuniversal mksolutionsuniversal left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer audit PASS.

  • Final head: 2a03bd6926dce4589c846725d4fa84610cbea236
  • 2 commits, 39 changed files.
  • SupportedIntelMac now derives from Apple hardware + Intel CPU without a model registry/whitelist.
  • Legacy ModelValidationLevel / model-support registry types are removed.
  • Supported UI no longer shows tested/untested or model-validation status; unsupported/incomplete platforms retain useful details.
  • Compatibility/diagnostic reports retain model identity, platform support, Gaming eligibility, power/Restore state and live fan capability diagnostics.
  • VerifiedHardwareModels.MacBookPro16_1 remains only for justified legacy schema-v1 downgrade compatibility and the bounded research round-trip tool; it is not a production writer permission gate.
  • No production FanControl, PowerManagement, Profiles, SettingsBackup or driver write semantics changed.
  • Local validation: 632/632 PASS, 0 warnings / 0 errors, diff-check PASS, packaging/safety scan PASS, zero physical SMC writes.
  • PR CI #180 on the exact head: full Build and test SUCCESS including Gate 5D-B and release packaging validation.

Ready for squash merge.

@mksolutionsuniversal
mksolutionsuniversal merged commit 467f62f into main Sep 8, 2026
1 check passed
@mksolutionsuniversal
mksolutionsuniversal deleted the release/0.5.0-rc.2-remove-model-validation branch September 8, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant